-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(citext): support postgres citext #2478
feat(citext): support postgres citext #2478
Conversation
Looks like you need to add |
@abonander thanks for pointing that out. I've went ahead and updated the postgres |
@hgranthorner CI is still failing. |
e881490
to
ededdcc
Compare
ededdcc
to
133c251
Compare
So my previous implementation of this was completely wrong. I assumed that because it worked for me, it would work for everyone, and due to some test setup issues (more on that below) I wasn't able to figure out how to test it beyond just running some samples. The new implementation follows the In terms of the testing issues, I ran into 2. I'm fairly certain that both of them are due to me being on Windows. For the first, the Long story short - sorry for wasting your time earlier. Things should (hopefully) be good now. Glad to take any and all feedback. |
Sorry for the delay. I have a few nits, but I'm just going to commit them as suggestions to avoid any more delays in getting this merged. |
* Rename `PgCitext` to `PgCiText` * Document when use of `PgCiText` is warranted * Document potentially surprising `PartialEq` behavior * Test that the macros consider `CITEXT` to be compatible with `String` and friends
* feat(citext): implement citext for postgres * feat(citext): add citext -> String conversion test * feat(citext): fix ltree -> citree * feat(citext): add citext to the setup.sql * chore: address nits to launchbadge#2478 * Rename `PgCitext` to `PgCiText` * Document when use of `PgCiText` is warranted * Document potentially surprising `PartialEq` behavior * Test that the macros consider `CITEXT` to be compatible with `String` and friends * doc: add `PgCiText` to `postgres::types` listing * chore: restore missing trailing line break to `tests/postgres/setup.sql` --------- Co-authored-by: Austin Bonander <austin@launchbadge.com>
@abonander Is there a timeline to release this on crates.io? |
Resolves #295
Users needed to explicitly cast all
CITEXT
columns toTEXT
. This set of changes will causeCITEXT
columns to be treated the same asTEXT
columns by sqlx.Happy to add additional details/code/comments/tests as needed.